Link component #6015
Link component #6015
Conversation
github-actions
bot
added
the
area/projects
|
🚀 Preview for commit dfa3836 at: https://6715fb00a753f1fc9c4fac02--layer5.netlify.app |
|
🚀 Preview for commit 3465ed8 at: https://6716033edc3fa002dc000554--layer5.netlify.app |
|
@NishantSinghhhhh I added the item to the docs: |
vishalvivekm
requested review from
SAHU-01,
sudhanshutech,
hargunkaur286 and
nebula-aac
|
@vishalvivekm thank you so much Sir |
|
🚀 Preview for commit b0d80fd at: https://67167a8c43c3d76be6961631--layer5.netlify.app |
|
🚀 Preview for commit e994890 at: https://671681a0c892347e07f863a7--layer5.netlify.app |
|
🚀 Preview for commit 1dbe06a at: https://67168a6c907aac827f285595--layer5.netlify.app |
|
I have implemented the necessary changes as requested in the meet #6015 Please review the updates, and if everything meets the project requirements, I would appreciate your help in merging the PR |
There was a problem hiding this comment.
@NishantSinghhhhh you can remove the topic download links , it doesn't make any sense because they same as basic links.
|
🚀 Preview for commit e11cdb4 at: https://67173635c015755baff8bf8c--layer5.netlify.app |
|
🚀 Preview for commit 63d5022 at: https://671748c932848974d5d28df5--layer5.netlify.app |
|
🚀 Preview for commit 34692ae at: https://67175cbd20e23e8a978c8e97--layer5.netlify.app |
|
🚀 Preview for commit 5685b94 at: https://671762903e850f867cc74570--layer5.netlify.app |
|
🚀 Preview for commit 0cf978c at: https://671768518c4e2890167f2ba2--layer5.netlify.app |
|
🚀 Preview for commit 0eb84e7 at: https://67177692c3a49aabdde6cabd--layer5.netlify.app |
|
@sudhanshutech , Sir I have done the changes you asked for |
|
🚀 Preview for commit 862f881 at: https://67178f868771dac5ab505ab9--layer5.netlify.app |
|
🚀 Preview for commit a284eee at: https://6717e2f552118e7e27667c8b--layer5.netlify.app |
|
@sudhanshutech ,DCO issue is now removed |
|
🚀 Preview for commit eb4dbf8 at: https://6718b156b7a10f825732289b--layer5.netlify.app |
|
Are there any other changes required that makes my code suitable to merge it in the main branch |
|
🚀 Preview for commit eb7ea29 at: https://67192c2db663b33fc5031454--layer5.netlify.app |
|
@NishantSinghhhhh Can you update your fork by resolving the confilct? |
Signed-off-by: NISHANT SINGH <[email protected]>
|
@nebula-aac , Sir I just resolved the conflicts , now it can be merged as it is free from conflicts |
Signed-off-by: NISHANT SINGH <[email protected]>
|
🚀 Preview for commit f5ebd91 at: https://671a51bda22f2904dedec717--layer5.netlify.app |
Signed-off-by: NISHANT SINGH <[email protected]>
Signed-off-by: NISHANT SINGH <[email protected]>
Signed-off-by: NISHANT SINGH <[email protected]>
Signed-off-by: NishantSinghhhhh <[email protected]>
NishantSinghhhhh
force-pushed
the
Link_Component
branch
from
4ee900d
to
59b3df4
Compare
|
@nebula-aac @sudhanshutech , Sir I have deleted the code-block.js and used an already made component |
Signed-off-by: NishantSinghhhhh <[email protected]>
Signed-off-by: NishantSinghhhhh <[email protected]>
|
🚀 Preview for commit b13dece at: https://671e132181a5f42297d489a5--layer5.netlify.app |
Description
Component Name : Link component present in Sistent component folder ,
This PR addresses various enhancements and features, including:
Documentation : I have written Documentation for the Link Component Used in Sistent Repository
Link Variants: Added different styles for links, including underlined and colored versions to enhance navigation and visibility.
Security Practices: Documented best practices for using links with target="_blank", highlighting the importance of rel="noopener" and rel="noreferrer" attributes to improve security.
Notes for Reviewers
Please pay special attention to the documentation and security notes for external links. Feedback on these changes would be greatly appreciated.
Signed commits**
Yes, I signed my commits.