added documentation of Link Component #6013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NishantSinghhhhh <[email protected]>
github-actions
bot
added
the
area/projects
|
@NishantSinghhhhh Thank you for your contribution! Please add it as an agenda item to the meeting minutes. |
|
@NishantSinghhhhh Can you check and fix the errors due to the github actions job? https://github.com/layer5io/layer5/actions/runs/11429709327/job/31796389728 |
|
@vishalvivekm Sir I am not able to edit the doc that you put in your previous comment ,thus I am not able to add my name in it |
|
@nebula-aac #6015 , I have created 1 more PR that passes all the test except the kanvas test , can you please review it |
|
Duplicate of #6015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Component Name : Link component present in Sistent component folder ,
This PR addresses various enhancements and features, including:
Documentation : I have written Documentation for the Link Component Used in Sistent Repository
Link Variants: Added different styles for links, including underlined and colored versions to enhance navigation and visibility.
Security Practices: Documented best practices for using links with target="_blank", highlighting the importance of rel="noopener" and rel="noreferrer" attributes to improve security.
Notes for Reviewers
Please pay special attention to the documentation and security notes for external links. Feedback on these changes would be greatly appreciated.
preview:
Signed commits**
Yes, I signed my commits.