Convert all png of sections directory to webp #5923
Conversation
|
I am waiting for your feedback |
|
🚀 Preview for commit b11dd86 at: https://66f1dadb46884513f1110169--layer5.netlify.app |
|
@Mandeep56Singh will you sign your commits. |
There was a problem hiding this comment.
@Mandeep56Singh did you check how much this saved us space?
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
1 similar comment
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Yaten Dhingra <[email protected]>
Bumps [@loadable/component](https://github.com/gregberge/loadable-components) from 5.15.3 to 5.16.4. - [Release notes](https://github.com/gregberge/loadable-components/releases) - [Changelog](https://github.com/gregberge/loadable-components/blob/main/CHANGELOG.md) - [Commits](gregberge/loadable-components@v5.15.3...v5.16.4) --- updated-dependencies: - dependency-name: "@loadable/component" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Mandeep56Singh <[email protected]>
Signed-off-by: Mandeep56Singh <[email protected]>
Mandeep56Singh
force-pushed
the
convertToWebP/sections
branch
from
b11dd86
to
ab412f0
Compare
|
@sudhanshutech looks like I maded a mistake 😅 in commit history is it a problem ? |
|
@sudhanshutech yes space has saved after |
|
🚀 Preview for commit d7d8699 at: https://66f451d19b40483e1f18f91c--layer5.netlify.app |
|
Thank you for your contribution @Mandeep56Singh Please add it as an agenda item to the meeting minutes. |
|
@vishalvivekm sorry, I wasn't able to attend the meeting, please tell if this pr need changes. I am not able to see the changes requested by @sudhanshutech. |
|
🚀 Preview for commit 01a808e at: https://66fd31a32515e4d7ee2ba398--layer5.netlify.app |
|
@Mandeep56Singh you might have rebased the commit please revert those changes. Either you can create a new pr and closing this one and in the new pr update to webp in chunks and not every images in same pr. |
@sudhanshutech please tell me, how to fix the mistake I created. |
|
you can create a new pr and create prs in chunks that is take lee number of file changes and in iterative way |
|
please open a new pr at will |
Description
This PR fixes ##5854
Notes for Reviewers
it converts all the png under src/sections directory to webP
and it resolves path
Signed commits