Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword the CTA text #5751

Closed
wants to merge 5 commits into from
Closed

reword the CTA text #5751

wants to merge 5 commits into from

Conversation

siddharthbaleja7
Copy link
Contributor

Description

This PR fixes #5717 by changing the text "Open Playground" to "Open in Demo System" as requested.

Desired Situation

The button text "Open Playground" should be changed to "Open in Demo System".

Contributor Resources and Handbook

Join the Layer5 Community by submitting your community member form.

Notes for Reviewers

  • Ensure that the text change is correctly applied.
  • Verify that the new text "Open in Demo System" is displayed appropriately in the UI.
  • Check for any typos or formatting issues.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: siddharthbaleja7 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 29, 2024

🚀 Preview for commit 6fc3f64 at: https://66a803d4bbc01e80152aa9e6--layer5.netlify.app

@siddharthbaleja7
Copy link
Contributor Author

@hargunkaur286 Can you please review this PR?

@siddharthbaleja7
Copy link
Contributor Author

@l5io Can you please review this PR?

@hargunkaur286 hargunkaur286 self-requested a review July 30, 2024 14:38
@hargunkaur286
Copy link
Member

@siddharthbaleja7 Can you share screenshots of the changes?

Copy link
Member

@hargunkaur286 hargunkaur286 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes had to be done in the Home Page
Screenshot 2024-07-30 at 8 17 44 PM

@hargunkaur286
Copy link
Member

// @vishalvivekm

@siddharthbaleja7
Copy link
Contributor Author

siddharthbaleja7 commented Jul 30, 2024

@l5io @hargunkaur286 should I make the changes in home page ?

@siddharthbaleja7
Copy link
Contributor Author

siddharthbaleja7 commented Jul 30, 2024

@l5io @hargunkaur286, here is the screenshot.
Screenshot 2024-07-30 at 21 57 51

@hargunkaur286
Copy link
Member

@l5io @hargunkaur286 should I make the changes in home page ?

Yes, please take reference from the issue description and the screenshot shared here.

@siddharthbaleja7
Copy link
Contributor Author

@l5io @hargunkaur286 Just for clarification, I need to change "use playground" to "open in demo system," right?

@hargunkaur286
Copy link
Member

@l5io @hargunkaur286 Just for clarification, I need to change "use playground" to "open in demo system," right?

yes

Signed-off-by: siddharthbaleja7 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 30, 2024

🚀 Preview for commit accc620 at: https://66a95426ef94da97aa4a64ce--layer5.netlify.app

@hargunkaur286
Copy link
Member

@siddharthbaleja7 please revert the changes from products/index.js file

Signed-off-by: siddharthbaleja7 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 30, 2024

🚀 Preview for commit d6712e8 at: https://66a95e1d9f477d0086d2a4a5--layer5.netlify.app

@siddharthbaleja7
Copy link
Contributor Author

@l5io @hargunkaur286 The reverts are done. Please review.

1 similar comment
@siddharthbaleja7
Copy link
Contributor Author

@l5io @hargunkaur286 The reverts are done. Please review.

@hargunkaur286
Copy link
Member

LGTM! 🚀

@siddharthbaleja7
Copy link
Contributor Author

@vishalvivekm Can you please review this PR?

1 similar comment
@siddharthbaleja7
Copy link
Contributor Author

@vishalvivekm Can you please review this PR?

@hargunkaur286
Copy link
Member

@vishalvivekm Can you please review this PR?

@siddharthbaleja7 The maintainers usually have a lot of PR's to review in the queue, so it would be nice, if you could be a bit patient, your PR will be reviewed. Meanwhile, please revert these changes:

Screenshot 2024-08-01 at 4 00 29 AM

Signed-off-by: siddharthbaleja7 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 31, 2024

🚀 Preview for commit e6a7840 at: https://66aac35e4d4fb62495c8a982--layer5.netlify.app

@siddharthbaleja7
Copy link
Contributor Author

@vishalvivekm Can you please review this PR?

@siddharthbaleja7 The maintainers usually have a lot of PR's to review in the queue, so it would be nice, if you could be a bit patient, your PR will be reviewed. Meanwhile, please revert these changes:

Screenshot 2024-08-01 at 4 00 29 AM

@hargunkaur286 The export default index; line has no changes from the original and does not need to be reverted. There should be no issue with keeping it as is.

@siddharthbaleja7
Copy link
Contributor Author

@vishalvivekm Can you please review this PR?

Signed-off-by: siddharthbaleja7 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 2, 2024

🚀 Preview for commit 175ce21 at: https://66ad1e8995b5979132e48c6d--layer5.netlify.app

@siddharthbaleja7 siddharthbaleja7 closed this by deleting the head repository Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

reword the CTA text
3 participants