Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Diagram page created #5197

Merged
merged 13 commits into from
Dec 22, 2023
Merged

AWS Diagram page created #5197

merged 13 commits into from
Dec 22, 2023

Conversation

iArchitSharma
Copy link
Contributor

@iArchitSharma iArchitSharma commented Dec 12, 2023 •
edited
Loading

ScreenShot

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@iArchitSharma
AWS Diagram page created
ec50b4f 
Signed-off-by: Archit Sharma <[email protected]>
@ritiksaxena124
Copy link
Contributor

@iArchitSharma what is the URL to get to this page?

@iArchitSharma
Copy link
Contributor Author

iArchitSharma commented Dec 12, 2023 •
edited
Loading

@ritiksaxena124 the build is still in progress but ill be <hostname>/cloud-native-management/aws-diagram
<hostname>/cloud-native-management/gcp-diagram

@l5io
Copy link
Contributor

l5io commented Dec 12, 2023

🚀 Preview for commit ec50b4f at: https://65786793f9d08e68c4ad8db4--layer5.netlify.app

@ashutosh-rath02
Copy link

Hey @iArchitSharma few tweaks.
image
Screenshot 2023-12-12 194601
You can center-align the section titles and maybe left align the excerpt below that.

leecalcote
leecalcote requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @iArchitSharma. Will you please reduce the amount of unused imports and CSS? The copy / pasta becomes both not tasty and unwieldy over time.

@l5io
Copy link
Contributor

l5io commented Dec 13, 2023

🚀 Preview for commit 2e11f4c at: https://657a2efa8e191d16ec550242--layer5.netlify.app

@iArchitSharma
updates
6c2a0ec 
Signed-off-by: Archit Sharma <[email protected]>
@iArchitSharma
Copy link
Contributor Author

@leecalcote Done

@l5io
Copy link
Contributor

l5io commented Dec 14, 2023

🚀 Preview for commit 6c2a0ec at: https://657aa56aa8f4d864bd0a8e43--layer5.netlify.app

@ritiksaxena124
Copy link
Contributor

@iArchitSharma

  1. we can remove this section
    image

  2. Reduce the line height of the title
    image

@iArchitSharma
Copy link
Contributor Author

@leecalcote @ritiksaxena124 Fixed the styling as requested and also added pushed GCP page

@iArchitSharma
Copy link
Contributor Author

iArchitSharma commented Dec 15, 2023 •
edited
Loading

Should I add the AWS and GCP pages under Solutions?

@l5io
Copy link
Contributor

l5io commented Dec 15, 2023

🚀 Preview for commit 8373a71 at: https://657c207ba4a9c45aad2bfe0f--layer5.netlify.app

leecalcote
leecalcote requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iArchitSharma the hero is too small. The hero graphic is also inappropriate for this page. When you have a new one, will you take a quick moment to toss in a subtle parallax effect?

@iArchitSharma
Copy link
Contributor Author

@leecalcote sure ill add subtle parallax effect once we have the hero image
@ritiksaxena124 do we have hero image for the two pages?

@ritiksaxena124
Copy link
Contributor

@leecalcote sure ill add subtle parallax effect once we have the hero image @ritiksaxena124 do we have hero image for the two pages?

not yet @iArchitSharma

@l5io
Copy link
Contributor

l5io commented Dec 21, 2023

🚀 Preview for commit ae77c61 at: https://65845ce8727b00c71e888c2c--layer5.netlify.app

@leecalcote
Copy link
Member

On the AWS page, the hero image is too small and not AWS specific. The subsequent graphics are not AWS specific either.

@l5io
Copy link
Contributor

l5io commented Dec 21, 2023

🚀 Preview for commit ecccde2 at: https://65848a3fb2a7d7303c4e8b69--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 21, 2023

🚀 Preview for commit 822ee6c at: https://6584b6dab2a7d74f204e8b29--layer5.netlify.app

ritiksaxena124
ritiksaxena124 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@ritiksaxena124 ritiksaxena124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are changes required @iArchitSharma, for now, I am merging this PR so that we have this page live.
Some fixes that are needed are :-

  1. Animation on hero image
  2. Mobile view fixes
  3. Increase hero image size etc...

@ritiksaxena124 ritiksaxena124 merged commit 4e392fc into layer5io:master Dec 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote requested changes

@ritiksaxena124 ritiksaxena124 ritiksaxena124 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iArchitSharma @ritiksaxena124 @l5io @ashutosh-rath02 @leecalcote