Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4ddx:fix/text-color-hover #4702

Merged
merged 1 commit into from
Aug 7, 2023
Merged

4ddx:fix/text-color-hover #4702

merged 1 commit into from
Aug 7, 2023

Conversation

4ddx
Copy link
Contributor

@4ddx 4ddx commented Aug 7, 2023

Signed-off-by: Ishan Kumar [email protected]
Description

This PR fixes #4615

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

fix text-color-hover to white on page

Signed-off-by: Ishan Kumar <[email protected]>
@4ddx
Copy link
Contributor Author

4ddx commented Aug 7, 2023

Sorry for the 3 earlier closed commits, the signoff wasn't configured properly

@l5io
Copy link
Contributor

l5io commented Aug 7, 2023

🚀 Preview for commit 6f359c6 at: https://64d10ccada73a510fc6af0c5--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @4ddx 👍

@4ddx
Copy link
Contributor Author

4ddx commented Aug 7, 2023

By the way, @leecalcote , I couldn't help but notice that similar behaviour (black text on hover) exists on one more page as well.

Want me to open a separate issue and fix it there? Or maybe you can open a new issue, and assign me?
Context:

Thanks!

@leecalcote leecalcote merged commit db80d42 into layer5io:master Aug 7, 2023
@4ddx 4ddx mentioned this pull request Aug 9, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Community] Five and Friends: text color on hover of card - too low contrast
3 participants