Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Banner-4 shuffling on page load with placeholder #3774

Open
leecalcote opened this issue Feb 17, 2023 · 19 comments
Open

Avoid Banner-4 shuffling on page load with placeholder #3774

leecalcote opened this issue Feb 17, 2023 · 19 comments
Labels
help wanted Extra attention is needed issue/remind kind/enhancement New feature or request language/css

Comments

@leecalcote
Copy link
Member

Current Behavior

On the homepage, banner, for will have its text, shuffled around on page load, while the short video is loaded on the right hand side.

Desired Behavior

Ideally, a placeholder is used or some other mechanism to ensure that the main text of the banner isn't jostled around while the video loads.

Screenshots / Mockups

Screenshot 2023-02-17 at 8 37 49 AM


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@leecalcote leecalcote added kind/enhancement New feature or request help wanted Extra attention is needed language/css labels Feb 17, 2023
@MrBehl06
Copy link

@leecalcote Please assign this issue to me?

@leecalcote
Copy link
Member Author

@MrBehl06 thanks for asking. Given your prior track record 😬, will you first prototype and propose a solution?

@oneknucklehead
Copy link

oneknucklehead commented Feb 18, 2023

Hey @leecalcote I believe we should implement skeleton loading for this. Not just for this, we can implement this wherever we are using images/gifs that takes time to fetch

@leecalcote
Copy link
Member Author

@oneknucklehead yes, an extremely lightweight placeholder, like an empty div that is configured under the same size constraints that the video is.

@MrBehl06
Copy link

@leecalcote I think We just need to add the margin-top and should decrease the max-width to 85% will solve this problem.
or else its position is relative we just add right margin.

Screenshot 2023-02-19 at 01 33 38

@oneknucklehead
Copy link

hey @leecalcote
Below Gif currently demonstrates my solution.
ezgif com-video-to-gif

@Avi-88
Copy link

Avi-88 commented Feb 25, 2023

hey @leecalcote Below Gif currently demonstrates my solution. ezgif com-video-to-gif ezgif com-video-to-gif

hey @leecalcote Below Gif currently demonstrates my solution. ezgif com-video-to-gif ezgif com-video-to-gif

@leecalcote I think We just need to add the margin-top and should decrease the max-width to 85% will solve this problem. or else its position is relative we just add right margin.

Screenshot 2023-02-19 at 01 33 38

Hi @MrBehl06 , regarding your approach , rather than using width or margin to solve this issue which most probably won't be consistent across varying screen sizes its better to use a skeleton as a placeholder for the video/image. @oneknucklehead's mockup looks promising , It just needs a little bit of tweaking to have the same dimensions as the media to be loaded. I would like to hear you guy's thoughts regarding the skeleton being an image similar to the media to be rendered or a classis pulsing gray div that is commonly used like below ,thanks

skeleton

@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 26, 2023
@Avi-88
Copy link

Avi-88 commented Apr 26, 2023

@oneknucklehead are you still up for proposing a fix for this ?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Apr 26, 2023
@shirsho-roy
Copy link

@leecalcote can you assign this to me? I would like to work on this issue

@Savio629
Copy link
Member

Savio629 commented Jun 1, 2023

@shirsho-roy Any updates?

@shirsho-roy
Copy link

@Savio629 Working on it

@Savio629
Copy link
Member

Any updates @shirsho-roy ?

@Savio629
Copy link
Member

@shirsho-roy Are you still working on this issue?

@leecalcote
Copy link
Member Author

Assignment seemingly abandoned. Opening for reassignment.

@saaagarsingh
Copy link
Contributor

Hey @leecalcote @Savio629 I would love to work on this.
Just need clarity that we need to have the space for video covered all the time so that text stays as it's position all the time even when the video is loading.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 15, 2023
@ankushbhardwaj408
Copy link
Member

Recording.2023-11-16.201242.mp4

@leecalcote take a look at this.

@saurabh100ni saurabh100ni removed the issue/stale Issue has not had any activity for an extended period of time label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed issue/remind kind/enhancement New feature or request language/css
Development

No branches or pull requests

10 participants