-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Banner-4 shuffling on page load with placeholder #3774
Comments
@leecalcote Please assign this issue to me? |
@MrBehl06 thanks for asking. Given your prior track record 😬, will you first prototype and propose a solution? |
Hey @leecalcote I believe we should implement skeleton loading for this. Not just for this, we can implement this wherever we are using images/gifs that takes time to fetch |
@oneknucklehead yes, an extremely lightweight placeholder, like an empty div that is configured under the same size constraints that the video is. |
@leecalcote I think We just need to add the margin-top and should decrease the max-width to 85% will solve this problem. |
hey @leecalcote |
Hi @MrBehl06 , regarding your approach , rather than using width or margin to solve this issue which most probably won't be consistent across varying screen sizes its better to use a skeleton as a placeholder for the video/image. @oneknucklehead's mockup looks promising , It just needs a little bit of tweaking to have the same dimensions as the media to be loaded. I would like to hear you guy's thoughts regarding the skeleton being an image similar to the media to be rendered or a classis pulsing gray div that is commonly used like below ,thanks |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@oneknucklehead are you still up for proposing a fix for this ? |
@leecalcote can you assign this to me? I would like to work on this issue |
@shirsho-roy Any updates? |
@Savio629 Working on it |
Any updates @shirsho-roy ? |
@shirsho-roy Are you still working on this issue? |
Assignment seemingly abandoned. Opening for reassignment. |
Hey @leecalcote @Savio629 I would love to work on this. |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Recording.2023-11-16.201242.mp4@leecalcote take a look at this. |
Current Behavior
On the homepage, banner, for will have its text, shuffled around on page load, while the short video is loaded on the right hand side.
Desired Behavior
Ideally, a placeholder is used or some other mechanism to ensure that the main text of the banner isn't jostled around while the video loads.
Screenshots / Mockups
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
master
branch.Join the Layer5 Community by submitting your community member form.
The text was updated successfully, but these errors were encountered: