Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect link in pr template in .github #326

Closed
Yana-Gupta opened this issue Aug 6, 2023 · 3 comments · Fixed by #329
Closed

incorrect link in pr template in .github #326

Yana-Gupta opened this issue Aug 6, 2023 · 3 comments · Fixed by #329
Assignees
Labels
kind/bug Something isn't working

Comments

@Yana-Gupta
Copy link

Yana-Gupta commented Aug 6, 2023

Current Behavior

The link to the Signed Commit is currently linking to the Not Found page in pr_template in github workflows here
Now it is:

../CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin

Expected Behavior

It should be changed to

https://github.com/layer5io/getnighthawk/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Resources

@Yana-Gupta Yana-Gupta added the kind/bug Something isn't working label Aug 6, 2023
@welcome
Copy link

welcome bot commented Aug 6, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@AryanSharma9917
Copy link
Contributor

Hey @leecalcote, could you please assign this issue to me?

@hirentimbadiya
Copy link
Member

go ahead @AryanSharma9917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants