-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow and keys spreadsheet #225
Add workflow and keys spreadsheet #225
Conversation
Signed-off-by: Mukesh Sharma <Yash.Sharma.1@studentambassadors>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Thanks for the new workflow @Yashsharma1911 |
Signed-off-by: Archit Sharma <[email protected]>
Feedback offered in today's meeting. |
assets/csv/keys.csv
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
…/Yashsharma1911/docs into yash/updatePermissionSpreadSheet
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash sharma <[email protected]>
Signed-off-by: Yash sharma <[email protected]>
Outside of assets directory it is giving issue @iArchitSharma , please see if you can fix and merge after that |
Signed-off-by: Archit Sharma <[email protected]>
@Yashsharma1911 we should remove csv from data directory |
Signed-off-by: Archit Sharma <[email protected]>
@Yashsharma1911 lets put the csv back to assets directory for now |
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Thankyou @iArchitSharma |
@iArchitSharma here are a few more things that can be improved:
I’m moving forward with PR, please consider updating these in your next PR. |
Notes for Reviewers
This PR fixes #
This PR adds generate keys workflow to generate and dump the spreadsheet and also adds spreasheet
Signed commits