Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow and keys spreadsheet #225

Merged

Conversation

Yashsharma1911
Copy link
Member

Notes for Reviewers

This PR fixes #

This PR adds generate keys workflow to generate and dump the spreadsheet and also adds spreasheet

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Mukesh Sharma <Yash.Sharma.1@studentambassadors>
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit f73025f
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/65e9fa2cc55f860007639cdd
😎 Deploy Preview https://deploy-preview-225--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
@iArchitSharma
Copy link
Contributor

iArchitSharma commented Mar 1, 2024

Thanks for the new workflow @Yashsharma1911
I've added the table in Reference page - https://deploy-preview-225--bejewelled-pegasus-b0ce81.netlify.app/cloud/reference/
image

@leecalcote
Copy link
Member

Feedback offered in today's meeting.

@leecalcote
Copy link
Member

The expected outcome of this effort looks like a single, dedicated page that lists the default roles with their default permissions (and has a link / info tip to how a docs page on how to customize them) and that perms table should look like this -
Screenshot 2024-03-01 at 3 57 55 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

Yashsharma1911 and others added 7 commits March 6, 2024 23:36
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
data/csv/keys.csv Outdated Show resolved Hide resolved
Signed-off-by: Yash sharma <[email protected]>
@Yashsharma1911
Copy link
Member Author

Outside of assets directory it is giving issue @iArchitSharma , please see if you can fix and merge after that

Signed-off-by: Archit Sharma <[email protected]>
@iArchitSharma
Copy link
Contributor

iArchitSharma commented Mar 7, 2024

@Yashsharma1911 we should remove csv from data directory
Refer - https://gohugo.io/functions/data/getcsv/
image

Signed-off-by: Archit Sharma <[email protected]>
@iArchitSharma
Copy link
Contributor

@Yashsharma1911 lets put the csv back to assets directory for now
i have changes location in shortcode to assets/data/keys.csv

Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
iArchitSharma and others added 4 commits March 7, 2024 21:33
@Yashsharma1911
Copy link
Member Author

Thankyou @iArchitSharma

@Yashsharma1911 Yashsharma1911 merged commit 0589de6 into layer5io:master Mar 7, 2024
6 checks passed
@Yashsharma1911
Copy link
Member Author

@iArchitSharma here are a few more things that can be improved:

  1. Default permissions page description (it can be more expressive).
  2. Audit and correct the incorrect checks for “User” role.
  3. Update customizable info with exact doc on how to customise permission maybe step by step guide, instead of redirecting user to a page which describes “what are keychains” instead of how to customise it.

I’m moving forward with PR, please consider updating these in your next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants