Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Homepage] Background SVGs need clipped #25

Closed
leecalcote opened this issue Oct 29, 2023 · 5 comments · Fixed by #33
Closed

[Homepage] Background SVGs need clipped #25

leecalcote opened this issue Oct 29, 2023 · 5 comments · Fixed by #33
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/css language/html

Comments

@leecalcote
Copy link
Member

Current Behavior

Scroll bars are unnecessarily made visible by background images that extend past the screen.

Screenshot 2023-10-29 at 2 55 53 PM

Expected Behavior

Decided homepage needs to avoid overflow and should clip any background images to the current viewport size.


Contributor Guides and Resources

@leecalcote leecalcote added good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/css language/html labels Oct 29, 2023
@ksauravhash
Copy link
Contributor

@leecalcote Can you assign me this issue? I have some experiance in MERN stack.

@leecalcote
Copy link
Member Author

Thanks, @ksauravhash! 👍

@leecalcote
Copy link
Member Author

Understand that the placement of the linear gradient divs is intentionally off screen, but that what is need is to clip / prevent overflow.

@ksauravhash
Copy link
Contributor

ksauravhash commented Nov 1, 2023

Is this how is this supposed to be? Should it be allowed to scroll in Y?
image

This was referenced Nov 1, 2023
@leecalcote
Copy link
Member Author

@ksauravhash scroll should be allowed until the end of the page footer is reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/css language/html
Development

Successfully merging a pull request may close this issue.

2 participants