Fix flaky test fire VMStorageClassWarning when rxbounce is disabled #1122
Conversation
kubevirt-bot
added
release-note-none
tests/monitoring_test.go
Outdated
| vm.Spec.Template.ObjectMeta.Annotations = map[string]string{ | ||
| "vm.kubevirt.io/os": "windows-10", | ||
| } | ||
| vm.Spec.Running = ptr.To(true) |
There was a problem hiding this comment.
Could you use RunStrategy instead?
There was a problem hiding this comment.
+1 because there is a plan to deprecate vm.Spec.Running.
There was a problem hiding this comment.
tests are failing because NewVirtualMachine is setting the vm.Spec.Running to false under the hood, and when I set the RunStrategy it errors with
Type: "FieldValueInvalid",
Message: "Running and RunStrategy are mutually exclusive",
Field: "spec.running",
There was a problem hiding this comment.
do I revert to use vm.Spec.Running for now until the NewVirtualMachine is also changed?
There was a problem hiding this comment.
changed in NewVirtualMachine
- Running: &running,
+ RunStrategy: ptr.To(kubevirtv1.RunStrategyHalted),
tests/monitoring_test.go
Outdated
| var volumes []kubevirtv1.Volume | ||
|
|
||
| if createDataVolume { | ||
| createPVCAndPV(vmName, rxbounceEnabled) | ||
|
|
machadovilaca
force-pushed
the
CNV-47434
branch
from
dde15db
to
6cca8e0
Compare
tests/monitoring_test.go
Outdated
| var always = kubevirtv1.RunStrategyAlways | ||
| vm.Spec.RunStrategy = &always |
There was a problem hiding this comment.
Any chance to do this in a single line? E.g.,
vm.Spec.RunStrategy = ptr.To(kubevirtv1.RunStrategyAlways)
machadovilaca
force-pushed
the
CNV-47434
branch
from
6cca8e0
to
605e22c
Compare
|
Thanks @machadovilaca! |
machadovilaca
force-pushed
the
CNV-47434
branch
from
605e22c
to
58ae7e4
Compare
Signed-off-by: João Vilaça <[email protected]>
machadovilaca
force-pushed
the
CNV-47434
branch
from
58ae7e4
to
79e2887
Compare
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Fix flaky test: [test_id:10549] Should fire VMStorageClassWarning when rxbounce is disabled
jira-ticket: https://issues.redhat.com/browse/CNV-47434
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: