Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove label needs-approver-review after either closed/merged or review by approver has happened #3712

Open
dhiller opened this issue Oct 25, 2024 · 5 comments
Open

Remove label needs-approver-review after either closed/merged or review by approver has happened #3712

dhiller opened this issue Oct 25, 2024 · 5 comments
Labels
area/automation Issues and PRs concerning automation, i.e. KubeVirt job updates, KubeVirtCI bumps etc. kind/enhancement

Comments

@dhiller
Copy link
Contributor

dhiller commented Oct 25, 2024

We should remove the label needs-approver-review after either the PR got merged/closed or after it got the review from an approver.
@dhiller
Copy link
Contributor Author

dhiller commented Oct 25, 2024

/kind enhancement

@dhiller
Copy link
Contributor Author

dhiller commented Oct 25, 2024

/area automation

@kubevirt-bot kubevirt-bot added the area/automation Issues and PRs concerning automation, i.e. KubeVirt job updates, KubeVirtCI bumps etc. label Oct 25, 2024
@dhiller dhiller mentioned this issue Oct 25, 2024
Merged
@dhiller
Copy link
Contributor Author

dhiller commented Nov 18, 2024

See #3763 for modification

@dhiller
Copy link
Contributor Author

dhiller commented Nov 19, 2024

Current status:

  • label is removed on closed/merged PRs
  • label is not applied on PRs where changes have been requested

@dhiller
Copy link
Contributor Author

dhiller commented Nov 19, 2024

Add GH team to manage the label: #3770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/automation Issues and PRs concerning automation, i.e. KubeVirt job updates, KubeVirtCI bumps etc. kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhiller @kubevirt-bot