Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] 🌱 Makefile: pin controller-gen binary to go 1.21 #10815

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Bumping to go 1.22 in kubekins broke controller-gen < 0.14.0 because of incompatibility to go >= 1.22

This pins compiling controller-gen to 1.21.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref: #10813

/area devtools

@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jun 28, 2024
@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2024
@chrischdi
Copy link
Member Author

/assign @sbueringer
/assign @fabriziopandini

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 96924a2234f9a9b04e92edf169162db4b5d83e5d

@sbueringer sbueringer changed the title 🌱 Makefile: pin controller-gen binary to go 1.21 [release-1.6] 🌱 Makefile: pin controller-gen binary to go 1.21 Jun 28, 2024
@sbueringer
Copy link
Member

sbueringer commented Jun 28, 2024

Very clean! Nice

/approve

For now let's just use this on a case-by-case basis whenever we need it. Eventually I want to have binary releases of controller-gen / setup-envtest so we can just download the binary instead of compiling it ourselves all the time.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 50b99f5 into kubernetes-sigs:release-1.6 Jun 28, 2024
25 checks passed
@chrischdi
Copy link
Member Author

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #10945

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants