-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.6] 🌱 Makefile: pin controller-gen binary to go 1.21 #10815
[release-1.6] 🌱 Makefile: pin controller-gen binary to go 1.21 #10815
Conversation
/assign @sbueringer |
96fb596
to
f2d6388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 96924a2234f9a9b04e92edf169162db4b5d83e5d
|
Very clean! Nice /approve For now let's just use this on a case-by-case basis whenever we need it. Eventually I want to have binary releases of controller-gen / setup-envtest so we can just download the binary instead of compiling it ourselves all the time. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
@chrischdi: new pull request created: #10945 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Bumping to go 1.22 in kubekins broke controller-gen < 0.14.0 because of incompatibility to go >= 1.22
This pins compiling controller-gen to 1.21.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):xref: #10813
/area devtools