Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken link in releasing.md #621

Closed
wants to merge 1 commit into from
Closed

Fixed broken link in releasing.md #621

wants to merge 1 commit into from

Conversation

Aayush987
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR removes the broken link from the releasing.md file and replaced with a valid one.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #620

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Aayush987. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2022
@jayesh-srivastava
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 7, 2022
@jayesh-srivastava
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2022
@jayesh-srivastava
Copy link
Member

/retitle Fixed broken link in releasing.md

@k8s-ci-robot k8s-ci-robot changed the title Broken List removed Fixed broken link in releasing.md Jun 7, 2022
jayesh-srivastava
jayesh-srivastava approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@jayesh-srivastava jayesh-srivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aayush987, jayesh-srivastava
To complete the pull request process, please assign timothysc after the PR has been reviewed.
You can assign the PR to them by writing /assign @timothysc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jayesh-srivastava
Copy link
Member

@CecileRobertMichon @fabriziopandini We can merge this PR as this will fix the broken link test.

@hrittikhere
Copy link
Contributor

Hey @jayesh-srivastava we have this as a duplicate for #613

I was requested to fix the broken link as well :)

@cpanato
Copy link
Member

cpanato commented Jun 8, 2022

since this pr is fixing broken links, I would say we fix all broken links and then we can merge this.

@cpanato
Copy link
Member

cpanato commented Jun 8, 2022

/hold to get all broken links fixed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@Aayush987
Copy link
Contributor Author

since this pr is fixing broken links, I would say we fix all broken links and then we can merge this.

Do i have to do something from my side?

@cpanato
Copy link
Member

cpanato commented Jun 8, 2022

since this pr is fixing broken links, I would say we fix all broken links and then we can merge this.

Do i have to do something from my side?

find the other broken links and get those updated :)

@Aayush987
Copy link
Contributor Author

since this pr is fixing broken links, I would say we fix all broken links and then we can merge this.

Do i have to do something from my side?

find the other broken links and get those updated :)

Ok, i will look for broken links in other files and get those updated.

@jayesh-srivastava
Copy link
Member

jayesh-srivastava commented Jun 8, 2022 •
edited
Loading

/lgtm cancel

@hrittikhere hrittikhere mentioned this pull request Jun 10, 2022
Merged
@Aayush987
Copy link
Contributor Author

Closing this pr, since the issue is already solved.

@Aayush987 Aayush987 closed this Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayesh-srivastava jayesh-srivastava jayesh-srivastava approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@jayesh-srivastava jayesh-srivastava

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link-check test failing due to a broken link.
5 participants
@Aayush987 @k8s-ci-robot @jayesh-srivastava @hrittikhere @cpanato