Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E] Add test to cover ResourceManagerTags #1053

Open
richardcase opened this issue Oct 26, 2023 · 6 comments
Open

[E2E] Add test to cover ResourceManagerTags #1053

richardcase opened this issue Oct 26, 2023 · 6 comments
Assignees
@salasberryfin
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@richardcase
Copy link
Member

/kind feature

Describe the solution you'd like

With #1008 support has been added for ResourceManagerTags. It would be good to ensure that we have this functionality covered by E2E tests.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 26, 2023
@richardcase
Copy link
Member Author

/help
/priority important-soon

@k8s-ci-robot
Copy link
Contributor

@richardcase:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 26, 2023
@richardcase richardcase mentioned this issue Oct 26, 2023
Merged
3 tasks
@salasberryfin
Copy link
Contributor

Following up on #1008, I'd be happy to take on this and add test cases.

/assign

@salasberryfin salasberryfin mentioned this issue Nov 16, 2023
Closed
@tasdikrahman
Copy link
Member

Hello there, @salasberryfin was wondering if you're still working on this.

@salasberryfin
Copy link
Contributor

Hi @tasdikrahman. If you're interested, you can take this from me, as I haven't been able to progress on this yet.

@richardcase
Copy link
Member Author

@tasdikrahman - did you want to get this from @salasberryfin ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salasberryfin salasberryfin

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@richardcase @tasdikrahman @salasberryfin @k8s-ci-robot