Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JX SCM: Support for detecting PR on Push Hook #7

Open
keskad opened this issue Nov 3, 2023 · 3 comments
Open

JX SCM: Support for detecting PR on Push Hook #7

keskad opened this issue Nov 3, 2023 · 3 comments
Labels
feat New feature or request idea receiver/jxscm JX SCM receiver
Milestone

Comments

@keskad
Copy link
Contributor

keskad commented Nov 3, 2023

Use case (Gitlab):

  • We want to test every commit, not only a Pull Request commit
  • Using Push Event we don't get PR ID, but every commit is triggering the Pipeline
  • Using Pull Request Push event we get PR ID, but only for commits belonging to a PR

Solution: A proposal to add a feature toggle to obtain PR id dynamically

@keskad keskad added feat New feature or request receiver/jxscm JX SCM receiver labels Nov 3, 2023
@GeoEducator
Copy link

Is there a get started guide, that suggests the benefits of this approach

@keskad
Copy link
Contributor Author

keskad commented Nov 8, 2023

@GeoEducator I'm not sure if I understand what do you mean, but trying to understand;

Is there a get started guide

This repository has no release yet, as I said on Slack it is expected within probably 2 weeks.
There is no getting started guide for bulidng a controller as well as for Tekton. Please feel free to submit an issue related to creation of getting started guide.

that suggests the benefits of this approach

You mean pipelines-feedback-core architecture at all or this detecting PR on Push Hook issue?

@keskad
Copy link
Contributor Author

keskad commented Nov 8, 2023

By the way you can subscribe for releases in the project main page to get a notification about release 🙂

@keskad keskad added the idea label Nov 18, 2023
@keskad keskad added this to the 2.0 (backlog) milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request idea receiver/jxscm JX SCM receiver
Projects
None yet
Development

No branches or pull requests

2 participants