Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] gang strategy enhancement #2244

Open
LY-today opened this issue Nov 1, 2024 · 6 comments
Open

[proposal] gang strategy enhancement #2244

LY-today opened this issue Nov 1, 2024 · 6 comments
Labels
area/koord-scheduler kind/proposal Create a report to help us improve

Comments

@LY-today
Copy link
Contributor

LY-today commented Nov 1, 2024

What is your proposal:
Add user wishes comments to the logic in the gang policy to prevent the gang policy from directly invalidating after the pod is destroyed and rebuilt.
if gang.getGangMatchPolicy() == extension.GangMatchPolicyOnceSatisfied && gang.isGangOnceResourceSatisfied() { return nil }

Why is this needed:
The gang policy immediately becomes invalid after the pod is destroyed and rebuilt. The newly created pod becomes running even when the total number of pods does not meet the MinRequiredNumber. However, some users think this does not meet their expectations. They believe that the semantics of the gang policy are still followed in this scenario. , so it is recommended to add user intention judgment logic

Is there a suggested solution, if so, please add it:
Annotation can be added to the podGroup, for example: gang.scheduling.koordinator.sh/close-history-evaluate. At this time, the rebuilt pod is destroyed. When the total number of pods does not meet the MinRequiredNumber, it is still pending, maintaining gang semantics.

ps:If the community thinks this capability suggestion is reasonable, I am willing to submit the corresponding PR.

@LY-today LY-today added the kind/proposal Create a report to help us improve label Nov 1, 2024
@ghost
Copy link

ghost commented Nov 1, 2024

I'm also experiencing this confusion, and I'm glad to see someone bringing it up. I would appreciate it if the author could take a look at this issue.

@Park-Jiyeonn
Copy link

I totally agree with this proposal. I've encountered similar issues where the gang policy behavior doesn't align with user expectations after a pod is destroyed and rebuilt. Keeping the gang semantics intact until the MinRequiredNumber is satisfied makes sense from a scheduling perspective. I support adding the user intention logic to address this.

Thank you for raising this issue, and I look forward to seeing it resolved!

@JBinin
Copy link
Contributor

JBinin commented Nov 1, 2024

I have encountered the same problem as the author. This proposal has been of great help to me. Thank you.

@saintube
Copy link
Member

saintube commented Nov 4, 2024

@LY-today Thanks for your suggestions. Feel free to self-assign if you are willing to contribute or have been working on it!

@saintube saintube changed the title gang strategy enhancement [proposal] gang strategy enhancement Nov 4, 2024
@LY-today
Copy link
Contributor Author

LY-today commented Nov 4, 2024

@LY-today Thanks for your suggestions. Feel free to self-assign if you are willing to contribute or have been working on it!

@saintube
First of all, I would like to ask if you agree with this feature enhancement? Secondly, do you agree that adding annotation annotations can solve this problem? I hope we can communicate the design method in advance, so that the progress will be smoother.

ps:I am very willing to submit the corresponding PR, and I will develop it after the communication is completed.

@LY-today
Copy link
Contributor Author

LY-today commented Nov 4, 2024

@saintube PR has been submitted, please check,#2246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koord-scheduler kind/proposal Create a report to help us improve
Projects
None yet
Development

No branches or pull requests

4 participants