@quarksb refactor: change Filter input and output #1806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarksb
changed the title
quarksb
changed the title
quarksb
changed the title
quarksb
changed the title
|
Hello, thanks for your pull request. I will also review another one that your submitted. For that one, I can say that I can't accept it because it is a very breaking change. Some devs may have custom filters, so switching from imageData to canvas will break the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1804
getImageData and put imageData is very slow, so I change imageData to Canvas, if you want use imageData, you must use getImageData by yourself in Filter