This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Add cilium as filter for benchmark #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new flags for the `run_tests.py` script. These are `--kubeconfig-calico-cluster` and `--kubeconfig-cilium-cluster`. User provides the path of the kubeconfig for a Lokomotive cluster that has Calico or Cilium installed. Updates the rest of the code where `kubectl` is called to refer to the kubeconfig passed instead of relying on the `KUBECONFIG` environment variable. Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
ipochi
force-pushed
the
imran/add-cilium-to-filter-for-benchmark
branch
from
253800c
to
bdd6611
Compare
This commit moves the ping and DNS check utility functions from main to util package in `pkg/filters/util/ping.go`. Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
This commit updates the `filter` interface method `Cleanup` to return an error as well. Update all the implementations to reflect the same. Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
ipochi
force-pushed
the
imran/add-cilium-to-filter-for-benchmark
branch
from
238017b
to
bcac3f7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Cilium as a benchmark filter for the framework.