Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(testbot): "all checks passed" but open tests #443

Open
srl295 opened this issue Apr 12, 2024 · 2 comments
Open

bug(testbot): "all checks passed" but open tests #443

srl295 opened this issue Apr 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@srl295
Copy link
Member

srl295 commented Apr 12, 2024

playground repro: keymanapp/keymanapp-test-bot-playground#14 (comment)

Production repro: keymanapp/keyman#11172 (comment)

Repro steps:

  1. create PR with @keymanapp-test-bot skip
  2. later, remove the skip and add a test suite in a comment

unclear if an intermediate half-baked test suite in the description (in addition to the comment) is needed.

@mcdurdin
Copy link
Member

mcdurdin commented Apr 12, 2024

It appears that if the text @keymanapp-test-bot skip is found anywhere in any comment in the PR, then the checks 'pass', although the labels show the actual state correctly.

I removed the @ from two comments (1, 2) in keymanapp/keyman#11172 and then status of checks was shown correctly.

@mcdurdin mcdurdin added the bug Something isn't working label Apr 12, 2024
@mcdurdin mcdurdin self-assigned this Apr 12, 2024
@mcdurdin mcdurdin modified the milestones: B17S6, 18.0 Apr 12, 2024
@mcdurdin
Copy link
Member

Will fix after beta release

@mcdurdin mcdurdin modified the milestones: 18.0, A18S2 Apr 29, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3, A18S7 May 24, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@darcywong00 darcywong00 modified the milestones: A18S9, A18S10 Aug 31, 2024
@darcywong00 darcywong00 modified the milestones: A18S10, A18S11 Sep 14, 2024
@darcywong00 darcywong00 modified the milestones: A18S11, A18S12 Sep 28, 2024
@darcywong00 darcywong00 modified the milestones: A18S12, A18S13 Oct 11, 2024
@darcywong00 darcywong00 modified the milestones: A18S13, A18S14 Oct 26, 2024
@mcdurdin mcdurdin modified the milestones: A18S14, A18S19 Nov 7, 2024
@mcdurdin mcdurdin modified the milestones: A18S19, Future Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants