Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrc.en.mtnt] Revise wordlist #178

Closed
Tracked by #7161
darcywong00 opened this issue Aug 30, 2022 · 8 comments · Fixed by #187
Closed
Tracked by #7161

[nrc.en.mtnt] Revise wordlist #178

darcywong00 opened this issue Aug 30, 2022 · 8 comments · Fixed by #187
Labels

Comments

@darcywong00
Copy link
Contributor

darcywong00 commented Aug 30, 2022

From a team review of the Keyman for Android UX (keymanapp/keyman#7161)

Aside from the contractions issue noted in #143, @mcdurdin notes the default English lexical-model wordlist needs the following adjustments:

Add common words such as:

  • Covid (the original wordlist gathered from reddit was pre-covid)
  • Qantas (airline) (and a number of other brands!)
  • Coronavirus

Remove these entries (along with any other typos found):

  • becasue 10
  • être 6
  • reccomend 5
  • sheild 5

Is there any value in keeping single-character entries (e.g. $ 1898)?

@mcdurdin
Copy link
Member

Yes, remove all single-character entries. Ideally the compiler should do this though...

@darcywong00
Copy link
Contributor Author

Some other suggestions that maybe should be lower-cased (relates to keymanapp/keyman#8164)
Some search results (there's tons more)

Hello
Yep
Ah
Apple (there's apples, but no lower-case apple. Granted this could be the company)
Ashes
Ape
Ark
Alternatively

@DavidLRowe
Copy link
Contributor

Is closing this issue waiting on #8164 mentioned above?

@darcywong00 darcywong00 linked a pull request Feb 11, 2023 that will close this issue
@darcywong00
Copy link
Contributor Author

Is closing this issue waiting on #8164 mentioned above?

Let's keep this issue open. #187 didn't address some of the typos or add new common words.

@DavidLRowe
Copy link
Contributor

#221 addresses some of the items raised on this issue. It's still a WIP, but review of the word list is welcome (particularly if there are words I've removed which should be reinstated).

@sgschantz
Copy link

@DavidLRowe, is this one fixed with #221?

image

@DavidLRowe
Copy link
Contributor

That is indeed one of the items removed in #221

@DavidLRowe
Copy link
Contributor

Some issues fixed by #221 , remainder moved to issue #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants