Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): establish builder.typescript.inc.sh and friends #12744

Open
mcdurdin opened this issue Nov 29, 2024 · 0 comments
Open

feat(common): establish builder.typescript.inc.sh and friends #12744

mcdurdin opened this issue Nov 29, 2024 · 0 comments
Labels
ci Issues relating to build infrastructure common/ feat
Milestone

Comments

@mcdurdin
Copy link
Member

  1. From a maintenance view, the builder_ prefix would make me assume this function is defined in builder.inc.sh with all the other builder_ functions.

I didn't want to put this into the main builder script, as it is specific to Typescript (and perhaps specific even to Developer use of Typescript; not sure it would transplant to /web for example). Ideally, we may have a set of builder sub-scripts, e.g. builder.typescript.inc.sh, builder.meson.inc.sh, etc, which we can draw from, and I would like to consider that for 19.0 (perhaps low pri though). shellHelperFunctions.sh is a bit of a random grab bag of functions that need refactoring and renaming, and eventually it should go away.

Originally posted by @mcdurdin in #12736 (comment)

@mcdurdin mcdurdin added this to the 19.0 milestone Nov 29, 2024
@mcdurdin mcdurdin added the ci Issues relating to build infrastructure label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues relating to build infrastructure common/ feat
Projects
Status: No status
Development

No branches or pull requests

1 participant