We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1.11
In lavacharts/src/Javascript/ScriptManager.php
on line 45 the statement: const JS_OPEN = '<script type="text/javascript">';
I assume this is the opening of all JavaScript.
According to W3 this should only be: const JS_OPEN = '<script>';
Testing on https://validator.w3.org/ gives a message like:
Warning: The type attribute is unnecessary for JavaScript resources.
From line 781, column 1; to line 781, column 31
v>↩↩<script type="text/javascript">↩!func
Is it an idea to change the definition of this const as described above?
The text was updated successfully, but these errors were encountered:
seems simple enough, submit a pull request? I'll merge that no problem.
Sorry, something went wrong.
No branches or pull requests
What Version?
3.1.11
Issue
In lavacharts/src/Javascript/ScriptManager.php
on line 45 the statement: const JS_OPEN = '<script type="text/javascript">';
I assume this is the opening of all JavaScript.
According to W3 this should only be: const JS_OPEN = '<script>';
Testing on https://validator.w3.org/ gives a message like:
Warning: The type attribute is unnecessary for JavaScript resources.
From line 781, column 1; to line 781, column 31
v>↩↩<script type="text/javascript">↩!func
Is it an idea to change the definition of this const as described above?
The text was updated successfully, but these errors were encountered: