-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: Create influxdb users #17
base: master
Are you sure you want to change the base?
Conversation
011ff26
to
06b2ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't through it in a lot of detail, but some comments!
|
||
- name: create influxdb proxy | ||
include_role: | ||
name: basic-site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is out,
site: influxdb-proxy | ||
site_name: influxdb proxy | ||
server_name: influxdb.yunity.org | ||
redirects: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work when using server-base for other playbooks which set these variables seperately? If the playbook-defined vars (e.g. playbooks/karrot-world/setup.playbook.yml
) correctly overwrite them, maybe add a note here to explain? Otherwise it's a bit confusing what they are kind of reused for a different purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another idea would be to just treat influxdb-proxy as a seperate site with it's own folder and playbooks...
Re: https://gitlab.com/kanthaus/kanthaus-private/issues/44
The idea is to: