Refactor kubelet config generation #5246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename
prepareLocalKubeletConfig
towriteKubeletConfig
and have this method not only generate the configuration data, but also write it to the designated file. Makes the Start method a bit shorter, and keeps related code snippets closer together. In this particular case, this eliminates an unnecessary string conversion back and forth. Move all kubelet config logic into that method, as well. This allows for dissolving thekubeletConfig
struct and make the assignments directly to the generatedKubeletConfiguration
struct. Removes unnecessary indirection and concentrates more of the decision making into the appropriate method. Defer OS-specific decisions about the path toresolv.conf
to the specific function, so that its return value is meaningful even if it's not called on Linux. Set the cgroups settings and do systemd detection only on Linux, as these are Linux-specific and don't exist on other operating systems.Type of change
How Has This Been Tested?
Checklist: