Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document constraints of dynamic config install #4559

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

juanluisvaladas
Copy link
Contributor

Description

I got a report of someone who had issues becuase the kubernetes.default.svc clusterIP was missing from the SANs of some control plane nodes. This happened because the certificate for kube-apiserver is generated without dynamic config. In the past we saw a similar issue with specifying spec.network.provider, but because it was reported in k0sctl we only fixed it for k0sctl.

We don't document anywhere this behavior but we copy it in k0sctl and in k0smotron we use the same configuration for every replica of the statefulset, we should tell .

Non-changeable fields can cause issues if not defined in the configuration file. This isn't immediately obvious by reading the docs so document it explicitly.

This was in the past

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue) (I consider this a documentation bug)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Non-changeable fields can cause issues if not defined in the
configuration file. This isn't immediately obvious by reading the docs
so document it explicitly.

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>
@juanluisvaladas juanluisvaladas added the backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch label Jun 6, 2024
@juanluisvaladas
Copy link
Contributor Author

Tagged it to backport to 1.30 only because the older versions need a manual backport due to CPLB.

@juanluisvaladas juanluisvaladas marked this pull request as ready for review June 6, 2024 10:37
@juanluisvaladas juanluisvaladas requested a review from a team as a code owner June 6, 2024 10:37
@twz123 twz123 added the documentation Improvements or additions to documentation label Jun 6, 2024
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's anything stopping us from actually supporting this to be dynamically reconciled? It currently feels like all that is needed is to add a Reconcile method to the Keepalived struct.

@juanluisvaladas
Copy link
Contributor Author

I wonder if there's anything stopping us from actually supporting this to be dynamically reconciled? It currently feels like all that is needed is to add a Reconcile method to the Keepalived struct.

I discussed this with Jussi back in the day and we agreed we didn't want to support this because:
1- kube-apiserver relies con CPLB, if something goes wrong this creates a chicken-egg situation.
2- Some fields such as the interface might be different on a per node basis, for instance the interface used for VRRP instances.

@twz123
Copy link
Member

twz123 commented Jun 7, 2024

1- kube-apiserver relies con CPLB, if something goes wrong this creates a chicken-egg situation.

I don't see why kube-apiserver is relying on that? If yes, then because users have actively configured it in that way.

2- Some fields such as the interface might be different on a per node basis, for instance the interface used for VRRP instances.

Right. Currently, k0s is only able to reconcile cluster-wide settings. Maybe that's something to be revisited in the future.

@juanluisvaladas
Copy link
Contributor Author

I don't see why kube-apiserver is relying on that? If yes, then because users have actively configured it in that way.

This is used to fill the SANs of the kube-apiserver certificate. I think that was the only thing where it affected apiserver.

@juanluisvaladas juanluisvaladas merged commit 5fb4f10 into k0sproject:main Jun 10, 2024
9 checks passed
@k0s-bot
Copy link

k0s-bot commented Jun 10, 2024

Successfully created backport PR for release-1.30:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants