Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you for your contribution, but I can't make sense of the three curves in Figure 3. #23

Open
Supzekun opened this issue Apr 15, 2024 · 3 comments

Comments

@Supzekun
Copy link

Supzekun commented Apr 15, 2024

Curve 1: Figure III left (Signal-to-noise ratio (SNR) of linear and cosine noise schedules for reference.) The relationship is given in your paper:

image
However when I use linear schedule locally, Diffusion Steps = 1000, and SNR by Equation 4, the curve is like this:
image
image


Curve 2: Figure III right(Weights of P2 weighting and the baseline with a linear schedule.)The relationship is given in your paper:

image
However when I use linear schedule locally, Diffusion Steps = 1000, and SNR by Equation 4, weight by
image
and P2-weight by
image
set k = 1, γ =1.
Also, I understand that you used the normalization operation: so I scaled weight to a range of 0 to 1 by maximum and minimum values
However, the curve I get is this:
image

These curves do not match at all the results you gave in your paper, did I do any step wrong? I am very interested in this article and look forward to your reply, thanks!

@Supzekun
Copy link
Author

Supzekun commented Apr 15, 2024

Attached below is the code I used to reproduce these curves:
image

@cheald
Copy link

cheald commented Apr 20, 2024

In your first graph, your y-axis is linear scale, while the SNR graph from the paper is log scale. Also note that the linear schedule has SNR as the x-axis, rather than timestep.

Using the DDPMScheduler scaled_linear betas formulation (ie, for Stable Diffusion), and using timestep for the lambda_prime series:

image

@Supzekun
Copy link
Author

In your first graph, your y-axis is linear scale, while the SNR graph from the paper is log scale. Also note that the linear schedule has SNR as the x-axis, rather than timestep.

Using the DDPMScheduler scaled_linear betas formulation (ie, for Stable Diffusion), and using timestep for the lambda_prime series:

image

I understand why, thank you very much for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants