You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, in the many examples involving combo/permuteIter, we take advantage of the fact that they return FALSE when iteration is complete, however it isn't documented anywhere.
Could we explicitly document this and maybe add more explanation behind the motivation of this design?
The text was updated successfully, but these errors were encountered:
jwood000
changed the title
Clarify documentation for combo/permuteIter
Clarify documentation for comboIter and permuteIter
Jun 11, 2020
We changed how iterators are handled by in db7cce2.
Instead of returning FALSE when iteration has been exhausted, we return NULL.
We initially thought that returning a logical made sense as it was in line with std::next_permutation from C++, however this causes problems when the source vector is logical or the FUN parameter is a logical check.
Currently, in the many examples involving
combo/permuteIter
, we take advantage of the fact that they returnFALSE
when iteration is complete, however it isn't documented anywhere.Could we explicitly document this and maybe add more explanation behind the motivation of this design?
The text was updated successfully, but these errors were encountered: