Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability issues #35

Open
viniciusdc opened this issue May 19, 2022 · 2 comments
Open

Vulnerability issues #35

viniciusdc opened this issue May 19, 2022 · 2 comments

Comments

@viniciusdc
Copy link

viniciusdc commented May 19, 2022

Greetings, recently we ran a security check (Trivy) in our installed Jupyter image (jupyterhub==1.5.0 )and spotted the following vulnerability issue, and looking over the discussion on #9 I thought it was worth mentioning those here:

CVE-2022-24785
High
Package: moment
Installed Version: 2.29.1
Vulnerability CVE-2022-24785
Severity: HIGH
Fixed Version: 2.29.2
Link: CVE-2022-24785

maybe relevant GHSA-8hfj-j24r-96c4
found in opt/conda/share/jupyterhub/static/components/moment/package.json:1
Thanks in advance.

@Carreau
Copy link
Member

Carreau commented May 24, 2022

Hi there, as far as I can tell this should not be an issue for JupyterHub as moment JS is used only on the client side.

CVE-2022-24785 says:

This vulnerability impacts npm (server) users of moment.js,

and you can see this is not used on the server as the path where this is found is .../static/... and JupyterHub is (mostly) written in Python.

We can still open an issue on jupyterHub to make sure they bump the minimal version.

Also in general, if you have doubt or want to talk about security issue you want to write to [email protected] that we monitor more closely and discussions there will be private.

@viniciusdc
Copy link
Author

Thanks, @Carreau for the details, I had this in mind as well but wanted to at least have this reported to confirm what exactly this would (or would not) affect. Thanks for opening the issue for bumping the version, feel free to close this as well if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants