Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't autograde students with backslash in their ID #912

Open
qlurkin opened this issue Nov 21, 2017 · 1 comment · May be fixed by #1881
Open

Can't autograde students with backslash in their ID #912

qlurkin opened this issue Nov 21, 2017 · 1 comment · May be fixed by #1881
Labels
bug good first issue
Milestone
0.8.1

Comments

@qlurkin
Copy link

qlurkin commented Nov 21, 2017

Operating system

Ubuntu 16.04.3

nbgrader --version

Python version 3.6.3 |Anaconda custom (64-bit)| (default, Oct 13 2017, 12:02:49)
[GCC 7.2.0]
nbgrader version 0.5.4

jupyterhub --version (if used with JupyterHub)

0.8.1

jupyter notebook --version

5.2.1

Expected behavior

The Autograde button of a submission in the "Manage Submissions" page should work even if the student ID contains Backslashes.

Actual behavior

The Autograde button of a submission in the "Manage Submissions" page don't work if the student ID contains Backslashes.
In my case the Backslashe comes from the fact that all student accounts are AD Domain accounts.

Steps to reproduce the behavior

  • Create a student with a backslash in his ID.
  • Make him submit an assignment with the web interface.
  • Collect the assignements with the web interface
  • Try to autograde the backslashed student with the web interface
@jhamrick
Copy link
Member

Confirmed. From a quick look, it seems as though the formgrader isn't properly encoding the URL because the error is a 404 error; it looks as though it's turning the backslash into a forward slash. For example, if my student id is foo\bar, then the logs show:

[W 22:36:54.080 NotebookApp] 404 POST /formgrader/api/submission/ps1/foo/bar/autograde (::1) 15.55ms referer=http://localhost:8889/formgrader/manage_submissions/ps1

Note the foo/bar rather than foo\bar.

@jhamrick jhamrick added the bug label Dec 12, 2017
@jhamrick jhamrick added this to the 0.6.0 milestone Dec 12, 2017
@jhamrick jhamrick modified the milestones: 0.6.0, 0.7.0 May 30, 2019
@jhamrick jhamrick modified the milestones: 0.7.0, 0.8.0 Mar 18, 2021
@jhamrick jhamrick modified the milestones: 0.8.0, 0.8.1 Jun 23, 2022
@sydfromm sydfromm linked a pull request Apr 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
0.8.1
Development

Successfully merging a pull request may close this issue.

Fix autograde for students with backslash in their ID sydfromm/nbgrader
2 participants
@jhamrick @qlurkin