Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should normalize update minor_version? #328

Open
vidartf opened this issue Nov 23, 2022 · 1 comment
Open

Should normalize update minor_version? #328

vidartf opened this issue Nov 23, 2022 · 1 comment
Labels

Comments

@vidartf
Copy link
Contributor

vidartf commented Nov 23, 2022

Currently if I run a v 4.0 notebook through nbformat.validator.normalize, it will add cell ids, but it will leave the minor version as 0. Shouldn't it be updated to 5 to highlight that it now includes some fields that was added in that version of the schema? Since the previous versions have the schema with additionalProperties: false, the new notebook will be invalid against the 4.0 schema.

@blink1073
Copy link
Contributor

Yes, it makes sense to me that whenever a normalize occurs, it should bump to the version that was used to normalize.

@blink1073 blink1073 added the bug label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants