Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script does not download new versions of jupyterlab css files #2180

Open
twanvl opened this issue Sep 24, 2024 · 1 comment
Open

Build script does not download new versions of jupyterlab css files #2180

twanvl opened this issue Sep 24, 2024 · 1 comment

Comments

@twanvl
Copy link

twanvl commented Sep 24, 2024

In hatch_build.py, a bunch of css files are downloaded. The urls include a version number (jupyterlab_css_version = "4.0.2"). But the script checks if the files already exists, and does not download them in that case. If previously an older version of the nbconvert was built, which downloaded older versions of the css files, then the css files are not updated.

I noticed this because the Debian python3-nbconvert package actually includes an old version of template/lab/style.css, which leads to weird styling issues. There might be more such subtly incorrect builds of nbconvert out there.

There should be a check to see that the existing files match jupyterlab_css_version.

@cjwatson
Copy link

Note that the proposed change here wouldn't have helped with the Debian bug in question anyway - Debian package builds can't download from the internet, so the Debian nbconvert package carries a patch to disable downloading CSS and embeds the files in question instead. (I'm updating them now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants