Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test extension loading order #61

Open
vidartf opened this issue May 26, 2021 · 2 comments
Open

Test extension loading order #61

vidartf opened this issue May 26, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@vidartf
Copy link
Contributor

vidartf commented May 26, 2021

A remaining task from #56 was to add tests for the intended behavior. This issue tracks that.

@vidartf vidartf added the enhancement New feature or request label May 26, 2021
@welcome
Copy link

welcome bot commented May 26, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@echarles
Copy link
Member

The sort logic is no more in nbclassic and implemented in notebook_shim https://github.com/jupyter/notebook_shim/blob/189915e9ff4b1c926c9439211fdf7f6767c1bb77/notebook_shim/nbserver.py#L84-L92

Should this issue be transferred to notebook_shim?

Also I wonder if the def _link_jupyter_server_extension(serverapp) is even used in notebook_shim as it is normally. a jupyter-server task. Should this be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants