Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "save as" to be able to create directories and to be able to infer the notebook name from the current notebook. #266

Open
andrewfulton9 opened this issue Nov 7, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@andrewfulton9
Copy link

Problem

Currently when you try to use "save as" you are limited to saving a file in an already existing folder and furthermore the full path of the new file (except for the .ipynb suffix) must be given. If the notebook name is not given in the path the only feedback you are given is that the text, "Enter a notebook path relative to the notebook dir", turns red:

nb_classic_save_as_folder.mp4

If you give a path that includes 1 or more folders that don't exist the error "No such file or directory":

nb_classic_save_as_new_folder.mp4

Proposed Solution

If no notebook name is given infer the name of the new notebook from the existing notebook. For example say you are working on notebook.ipynb in the root directory, and typed existing_folder/ into the save as dialog the new notebook would be saved to existing_folder/notebook.ipynb.

For paths that contain new folders, open a dialog giving the option to cancel the save as operation, or to create the directory, similar to how overwriting a file from save as works.

Additional context

These changes will behave similarly to JupyterLab current functioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants