Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for platform dirs affecting downstream CI tests #310

Open
jasongrout opened this issue Nov 9, 2022 · 1 comment
Open

Comments

@jasongrout
Copy link
Member

jasongrout commented Nov 9, 2022

This is going to be a bit rough:

https://github.com/ipython/ipython/actions/runs/3428540614/jobs/5712956265#step:7:76

We might be halting a lot of downstream CI builds by having a deprecation warning that essentially is on by default (which in a CI test is converted to an error).

Perhaps we delete the deprecation warning and figure out a lighter way to tell users about the upcoming new default. @blink1073, what do you think?

@blink1073
Copy link
Contributor

We're already handling this in several other downstream consumers, e.g. https://github.com/jupyter-server/jupyter_server/blob/f6b732c652e0b5a600ff0d3f60c6a34173d8d6a5/pyproject.toml#L145. I think that is part of the responsibility of handling warnings as errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants