Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate writes marker file in read only directory #181

Open
robertlugg opened this issue Feb 6, 2020 · 1 comment
Open

migrate writes marker file in read only directory #181

robertlugg opened this issue Feb 6, 2020 · 1 comment

Comments

@robertlugg
Copy link

I have defined JUPYTER_CONFIG_DIR which points to a directory which is read only. When migration.py tries to "touch" a marker file, it fails. This makes placing your config file in a read-only location not possible (such as inside a container).

Please refer to this line:

with open(os.path.join(env['jupyter_config'], 'migrated'), 'w') as f:

My suggestion is to instead just silently fail if not possible to write.

@jasongrout
Copy link
Member

My suggestion is to instead just silently fail if not possible to write.

That makes sense to me. Can you submit a PR?

Is this the only issue you are seeing with a read only config directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants