Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binder Frontmatter field is ignored by thebe #504

Open
agoose77 opened this issue Nov 28, 2024 · 1 comment
Open

binder Frontmatter field is ignored by thebe #504

agoose77 opened this issue Nov 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@agoose77
Copy link
Collaborator

Right now, it's not easy to specify a custom mybinder URL, e.g. the obvious:

version: 1
project:
  binder: https://binder.opensci.2i2c.cloud/
  github: https://github.com/2i2c-org/demo-icepyx

Instead, we have to write:

version: 1
project:
  jupyter:
    binder:
      repo: https://github.com/2i2c-org/demo-icepyx
      url: https://binder.opensci.2i2c.cloud/

  github: https://github.com/2i2c-org/demo-icepyx

This seems to be because we don't listen (at all?) to the project.binder Frontmatter entry for anything.

@agoose77 agoose77 added the bug Something isn't working label Nov 28, 2024
@stevejpurves
Copy link
Contributor

yes, correct I think we should remove that. Historically, way back(TM), project.binder was being used to display a classic [launch | binder] badge in the frontmatter, prior to even thebe being integrated IIRC. The theme's don't support it so we should drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants