Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First known part should not add top margin (article theme) #453

Open
stevejpurves opened this issue Aug 22, 2024 · 1 comment
Open

First known part should not add top margin (article theme) #453

stevejpurves opened this issue Aug 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@stevejpurves
Copy link
Contributor

Looking at getting consistent alignment, we should consider that elements in the main article (or other nav elements) do not add top margin, but leave layout to the parent component.

for example here, the top margin on the abstract part causes misalignment, and we cannot compensate for that by moving the outline as that is content dependendent, if there were no parts or keyworks, we would have an h1 at the top with no margin and good alignment for the current document outline position.

La Palma Seismicity 2021 - La Palma Earthquakes 🔊 2024-08-22 10-38-05

If the Abstract h2 tag did not add it's margin, everything would be well aligned:

La Palma Seismicity 2021 - La Palma Earthquakes 🔊 2024-08-22 10-35-05

So are we able to do something to ensure that the first element in the main body of content does not introduce a margin? or otherwsise is there a way to ensure alignment to the top of the main grid?

@stevejpurves stevejpurves added the bug Something isn't working label Aug 22, 2024
@agoose77
Copy link
Collaborator

@stevejpurves I think part of this is that the h2 for the abstract should not be padded. To my mind, it's a separate styling path to the regular h2 in an article. c.f. #450

I wonder whether we just need to do the same will all of the other elements that can end up in the article body (and use bottom margins if appropriate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants