Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certain bold & italics broken after leaving Goyo #250

Open
daveriedstra opened this issue Apr 27, 2021 · 5 comments
Open

certain bold & italics broken after leaving Goyo #250

daveriedstra opened this issue Apr 27, 2021 · 5 comments

Comments

@daveriedstra
Copy link

issue

When using a plugin for markdown syntax (such as vim-markdown or vim-pandoc-syntax), leaving Goyo removes formatting for *italic* and **bold** elements (and underscore variants), though the asterisks / underscores remain concealed properly. Other bold and italic formatting (such as # headings) works, which makes me think this is somehow related to concealing.

reproduce

  1. open or create a markdown file with some _italic_, __bold__, *italic*, or **bold** formatting
    image

  2. enter Goyo mode

  3. observe formatting is correct
    image

  4. leave Goyo mode

  5. observe formatting lost
    image

  6. enter Goyo mode

  7. observe formatting still lost
    image

other details

  • NVIM 0.4.4
  • also affects VIM 8.2
  • vim-markdown 1.0.0 or vim-pandoc-syntax latest
  • goyo latest
@felipejoribeiro
Copy link

I also have this problem in NVIM 0.5.0.

@realshovanshah
Copy link

Confirming that the issue with conceal being 'reset' is also happening in Vim 9

@Rubiginosa
Copy link

I traced this issue down to line 342 in autoload/goyo.vim: execute 'colo '. get(g:, 'colors_name', 'default')
Commenting out the line fixes the problem, but I haven't looked at the design enough yet to know if this is an acceptable fix.

@Rubiginosa
Copy link

Ah, any call to colorscheme seems to break concealing with my current setup, so this isn't exactly goyo-specific

@Rubiginosa
Copy link

fixed by adding autocmd colorscheme * syntax on to my vimrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants