Experimental support for Kitty graphics protocol should be flagged as "Linux/Mac" only

[jeansagi]

As Kitty is not ported to Windows yet, the Kitty graphics protocol fzf 0.43.0 supports should be clearly advertised as Linux/Mac only so clueless Windows users (like me) don't try this option!

;)

J.

[kovidgoyal]

The kitty graphics protocol is not implemented only in kitty. It exists, for instance, at least partially in wezterm which runs on windows.

[junegunn]

Good point. I updated the release note.

The way fzf implements the Kitty graphics protocol is to simply pass through regions of text that correspond to the graphics data to the underlying terminal.

fzf/src/tui/light.go

Lines 34 to 37 in d51b71e

	func (r *LightRenderer) PassThrough(str string) {
	r.queued.WriteString(str)
	r.flush()
	}

However, if I'm not mistaken, the tcell library we use for the Windows build does not provide such a "pass-through" mechanism, so it is not currently supported on the fzf side.

fzf/src/tui/tcell.go

Lines 101 to 104 in d51b71e

	func (r *FullscreenRenderer) PassThrough(str string) {
	// No-op
	// https://github.com/gdamore/tcell/issues/363#issuecomment-680665073
	}

[jeansagi]

Obviously it depends on several factors, but it would be awesome to be able to view images in fzf on Windows.

And BTW, Using Kitty on Windows would be awesome too.

J.

[junegunn]

With 68db9cb, it will work on Windows as well (though I haven't actually tested it on Windows).

[junegunn]

Nope. 38e3694