-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-evaluate icecave dependency #753
Comments
Thanks for issue report. Is this something you've already did some investigation into or have some knowledge about? |
It's purely a reminder. |
@W0rma The dependency on An alternative to the dependency would be to implement proper deep comparison in this library. |
Both PHPUnit has a (very) good way of comparing "things", and PHPUnit's author has released the compare component under https://github.com/sebastianbergmann/comparator. It may be a good candidate to swap out |
#518 added the dependency to
icecave/parity
.In composer/composer#12039 (comment) it was recommended to check whether this dependency is really necessary:
I just created this issue to not forget about this evaluation.
The text was updated successfully, but these errors were encountered: