Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor possible issue #2

Open
Baza-1969 opened this issue Jul 30, 2020 · 1 comment
Open

Minor possible issue #2

Baza-1969 opened this issue Jul 30, 2020 · 1 comment

Comments

@Baza-1969
Copy link

Baza-1969 commented Jul 30, 2020

Just a quick one Justin - This is great work!.
Looks like your electrical schematic has the buttons going sequentially from bottom to top 1-4?
Button 1 and 2 look ok, but buttons 3 & 4 seem to be going to the wrong pins according to you GPIO assigment on Tinderbox.py (assuming the schematic buttons are drawn from 1 to 4 sequentially upwards)
Button 3 goes to 19 / button 4 goes to 26
This could cause confusion, with button 3 operating preset 4 and visa versa - easily fixed with labelling the schematic buttons?

@jrnelson90
Copy link
Owner

I agree, I did that schematic very quickly last night so I could go to bed. I'll be working on a much better one. I just need to reorient myself with Kicad or Eagle, it's been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants