Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document changes in boolean attributes treatment #1243

Open
mgol opened this issue Mar 18, 2024 · 2 comments · May be fixed by #1263
Open

Document changes in boolean attributes treatment #1243

mgol opened this issue Mar 18, 2024 · 2 comments · May be fixed by #1263
Labels
Has Pull Request
Milestone
4.0.0

Comments

@mgol
Copy link
Member

mgol commented Mar 18, 2024

See jquery/jquery#5452
@mgol mgol added this to the 4.0.0 milestone Mar 18, 2024
This was referenced Mar 18, 2024
Merged
Closed
@gibson042
Copy link
Member

The table in .attr( attributeName ) will need a new row for 4.0+, and .attr( attributeName, value ) will need updates to document the acceptability of a false value and its removal behavior which is similar to null behavior except with "aria-" attributes.

Proposed text for the latter:

Note: because ARIA attributes frequently associate behavior with "false" values that differs from attribute absence, passing false as the value for an attribute whose name starts with "aria-…" will stringify that value to "false" rather than remove the attribute. To guarantee removal of an attribute, provide null as the value or use the .removeAttr() method.

mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 8, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
e511899 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
@mgol mgol mentioned this issue Oct 8, 2024
Merged
mgol added a commit to mgol/api.jquery.com that referenced this issue Oct 9, 2024
@mgol
Attr: Document jQuery 4 boolean attribute changes; add a 4.0 version …
5f0da17 
…category

Fixes jquerygh-1243
Ref jquery/jquery#5452
Ref jquery/jquery-migrate#540
@mgol mgol mentioned this issue Oct 9, 2024
Closed
@mgol
Copy link
Member Author

mgol commented Oct 9, 2024

PR: #1254

mgol added a commit to mgol/api.jquery.com that referenced this issue Oct 9, 2024
@mgol
Attr: Document jQuery 4 boolean attribute changes
8f04428 
Fixes jquerygh-1243
Ref jquery/jquery#5452
Ref jquery/jquery-migrate#540
mgol added a commit to mgol/api.jquery.com that referenced this issue Oct 9, 2024
@mgol
Attr: Document jQuery 4 boolean attribute changes
7095a49 
Fixes jquerygh-1243
Ref jquery/jquery#5452
Ref jquery/jquery-migrate#540
mgol added a commit to mgol/api.jquery.com that referenced this issue Oct 14, 2024
@mgol
Attr: Document jQuery 4 boolean attribute changes
c85a4c9 
Fixes jquerygh-1243
Ref jquery/jquery#5452
Ref jquery/jquery-migrate#540
@mgol mgol linked a pull request Oct 14, 2024 that will close this issue
Open
mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 15, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
39ccd8b 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 28, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
65a03af 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 29, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
7872ddd 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
mgol added a commit to jquery/jquery-migrate that referenced this issue Nov 19, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3…
5471109 
….x (#540)

Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes gh-504
Closes gh-540
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Has Pull Request
Milestone
4.0.0
2 participants
@gibson042 @mgol