From daebcf2dee3b7a11d535617889c5572aeb7449c2 Mon Sep 17 00:00:00 2001 From: Park Sanggeon Date: Mon, 12 Mar 2018 12:09:38 +0100 Subject: [PATCH 1/2] removed warning for Documentation Comments. --- Classes/JSONAPIResourceDescriptor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/JSONAPIResourceDescriptor.h b/Classes/JSONAPIResourceDescriptor.h index 840842f..01eaf29 100644 --- a/Classes/JSONAPIResourceDescriptor.h +++ b/Classes/JSONAPIResourceDescriptor.h @@ -101,7 +101,7 @@ * Add a simple property with custom json name. * * @param name The name of the property in the class. - * @param jsonName The label of the property in JSON. + * @param json The label of the property in JSON. */ - (void)addProperty:(NSString*)name withJsonName:(NSString *)json; From 4249418bb3daec12462bb8f4d4f8d75b43b0e082 Mon Sep 17 00:00:00 2001 From: Park Sanggeon Date: Mon, 12 Mar 2018 12:23:04 +0100 Subject: [PATCH 2/2] updated project settings. --- Project/JSONAPI.xcodeproj/project.pbxproj | 33 +++++++++++++++++-- .../xcshareddata/xcschemes/JSONAPI.xcscheme | 15 ++++++--- Project/JSONAPI/JSONAPI-Info.plist | 2 +- Project/JSONAPITests/JSONAPITests-Info.plist | 2 +- 4 files changed, 42 insertions(+), 10 deletions(-) diff --git a/Project/JSONAPI.xcodeproj/project.pbxproj b/Project/JSONAPI.xcodeproj/project.pbxproj index 11cfa41..5d23671 100644 --- a/Project/JSONAPI.xcodeproj/project.pbxproj +++ b/Project/JSONAPI.xcodeproj/project.pbxproj @@ -336,7 +336,7 @@ 03A055AF1868E038004807F0 /* Project object */ = { isa = PBXProject; attributes = { - LastUpgradeCheck = 0620; + LastUpgradeCheck = 0920; ORGANIZATIONNAME = "Josh Holtz"; TargetAttributes = { 03A055D71868E038004807F0 = { @@ -494,18 +494,30 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; + CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; + CLANG_WARN_SUSPICIOUS_MOVE = YES; + CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; COPY_PHASE_STRIP = NO; + ENABLE_STRICT_OBJC_MSGSEND = YES; + ENABLE_TESTABILITY = YES; GCC_C_LANGUAGE_STANDARD = gnu99; GCC_DYNAMIC_NO_PIC = NO; + GCC_NO_COMMON_BLOCKS = YES; GCC_OPTIMIZATION_LEVEL = 0; GCC_PREPROCESSOR_DEFINITIONS = ( "DEBUG=1", @@ -518,7 +530,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 7.0; + IPHONEOS_DEPLOYMENT_TARGET = 8.0; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; }; @@ -532,25 +544,36 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; + CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; + CLANG_WARN_SUSPICIOUS_MOVE = YES; + CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; COPY_PHASE_STRIP = YES; ENABLE_NS_ASSERTIONS = NO; + ENABLE_STRICT_OBJC_MSGSEND = YES; GCC_C_LANGUAGE_STANDARD = gnu99; + GCC_NO_COMMON_BLOCKS = YES; GCC_WARN_64_TO_32_BIT_CONVERSION = YES; GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNDECLARED_SELECTOR = YES; GCC_WARN_UNINITIALIZED_AUTOS = YES; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 7.0; + IPHONEOS_DEPLOYMENT_TARGET = 8.0; SDKROOT = iphoneos; VALIDATE_PRODUCT = YES; }; @@ -564,6 +587,7 @@ GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "JSONAPI/JSONAPI-Prefix.pch"; INFOPLIST_FILE = "JSONAPI/JSONAPI-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "com.joshholtz.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; WRAPPER_EXTENSION = app; }; @@ -577,6 +601,7 @@ GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "JSONAPI/JSONAPI-Prefix.pch"; INFOPLIST_FILE = "JSONAPI/JSONAPI-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "com.joshholtz.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; WRAPPER_EXTENSION = app; }; @@ -598,6 +623,7 @@ "$(inherited)", ); INFOPLIST_FILE = "JSONAPITests/JSONAPITests-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "com.joshholtz.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; TEST_HOST = "$(BUNDLE_LOADER)"; WRAPPER_EXTENSION = xctest; @@ -616,6 +642,7 @@ GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "JSONAPI/JSONAPI-Prefix.pch"; INFOPLIST_FILE = "JSONAPITests/JSONAPITests-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "com.joshholtz.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; TEST_HOST = "$(BUNDLE_LOADER)"; WRAPPER_EXTENSION = xctest; diff --git a/Project/JSONAPI.xcodeproj/xcshareddata/xcschemes/JSONAPI.xcscheme b/Project/JSONAPI.xcodeproj/xcshareddata/xcschemes/JSONAPI.xcscheme index 5d02e46..5a06795 100644 --- a/Project/JSONAPI.xcodeproj/xcshareddata/xcschemes/JSONAPI.xcscheme +++ b/Project/JSONAPI.xcodeproj/xcshareddata/xcschemes/JSONAPI.xcscheme @@ -1,6 +1,6 @@ + language = "" + shouldUseLaunchSchemeArgsEnv = "YES"> @@ -48,15 +49,19 @@ ReferencedContainer = "container:JSONAPI.xcodeproj"> + + @@ -72,10 +77,10 @@ diff --git a/Project/JSONAPI/JSONAPI-Info.plist b/Project/JSONAPI/JSONAPI-Info.plist index e9d673e..6667e41 100644 --- a/Project/JSONAPI/JSONAPI-Info.plist +++ b/Project/JSONAPI/JSONAPI-Info.plist @@ -9,7 +9,7 @@ CFBundleExecutable ${EXECUTABLE_NAME} CFBundleIdentifier - com.joshholtz.${PRODUCT_NAME:rfc1034identifier} + $(PRODUCT_BUNDLE_IDENTIFIER) CFBundleInfoDictionaryVersion 6.0 CFBundleName diff --git a/Project/JSONAPITests/JSONAPITests-Info.plist b/Project/JSONAPITests/JSONAPITests-Info.plist index cb4386a..169b6f7 100644 --- a/Project/JSONAPITests/JSONAPITests-Info.plist +++ b/Project/JSONAPITests/JSONAPITests-Info.plist @@ -7,7 +7,7 @@ CFBundleExecutable ${EXECUTABLE_NAME} CFBundleIdentifier - com.joshholtz.${PRODUCT_NAME:rfc1034identifier} + $(PRODUCT_BUNDLE_IDENTIFIER) CFBundleInfoDictionaryVersion 6.0 CFBundlePackageType