Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LessPHP outdated #6845

Closed
Hackwar opened this issue Apr 25, 2015 · 7 comments
Closed

LessPHP outdated #6845

Hackwar opened this issue Apr 25, 2015 · 7 comments

Comments

@Hackwar
Copy link
Member

Hackwar commented Apr 25, 2015

Our current LessPHP version is 0.3.9, the current one is 0.5.0: https://github.com/leafo/lessphp

Even if there is a B/C break in that library there, we should really update this and see if we can somehow catch the change in our extending J class.

@Bakual
Copy link
Contributor

Bakual commented Apr 25, 2015

To my knowledge, the newer releases are not compatible with Bootstrap 2.3.2. Which is why we never updated it.
I don't know what exactly isn't compatible.

@mbabker
Copy link
Contributor

mbabker commented Apr 25, 2015

http://leafo.net/lessphp/changelog.html somewhat explains why we're stuck on the version we have. If you can find the breaking change (leafo/lessphp@v0.3.9...v0.4.0) maybe we can catch it in JLess.

@ghost
Copy link

ghost commented Apr 26, 2015

I'm using lessc 0.4.0 with Joomla 3 (/media/jui/less/) for a long time now and never had any problems.
Today I made some tests with template.less from Isis and Protostar (lessc 0.3.9, 0.4.0, 0.5.0) and got exactly the same outputfiles template.css.
(I don't know if your discussion is going deeper than that. I never used JLess but the same default vars from class JLessFormatterJoomla for compilation )

@PLFoxNET
Copy link

Welcome,

I have a question, is there a way to file "libraries / fof / less / less.php" at the template level override? In Joomla 3.4 is still version 0.3.9, and I would like in one template to use newer versions 0.5.0

Is this feasible?

@Bakual
Copy link
Contributor

Bakual commented Jul 23, 2015

You can't override it. But of course you can ship your own copy and use it in your template. Just require_once your copy and use it.

@brianteeman
Copy link
Contributor

Setting to needs review so the CMS maintainers can make a decision on upgrading this or not.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6845.

@Bakual
Copy link
Contributor

Bakual commented Nov 12, 2015

This can be closed since we have a PR for that: #7687

@Bakual Bakual closed this as completed Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants