What is the point of calling the same method 2 times with the same parameters?

[korenevskiy]

joomla-cms/administrator/components/com_fields/src/Plugin/FieldsPlugin.php

Line 149 in 63d4e65

$path = PluginHelper::getLayoutPath('fields', $this->_name, $field->type);

joomla-cms/administrator/components/com_fields/src/Plugin/FieldsPlugin.php

Line 153 in 63d4e65

$path = PluginHelper::getLayoutPath('fields', $this->_name, $field->type);

What is the point of calling the same method 2 times with the same parameters?

[PhilETaylor]

Nothing to do with me. Talk to @laoneo

References:

• Use plugin name for path lookup #28516 (comment)

• [4.0] Use only plugin name for path lookup #28534

• Use plugin name for path lookup #28516

[korenevskiy]

Thanks. It's just that you are listed there as a contributor.

[korenevskiy]

@astridx @laoneo @astridx

[astridx]

@korenevskiy Did you see the conversation in this PR #28516 ?

[laoneo]

I guess this is a bug as it was wrongly merged up from 3. Compare the two files:

• https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_fields/src/Plugin/FieldsPlugin.php#L149
• https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_fields/libraries/fieldsplugin.php#L125
  When you look on the original pr [4.0] Use only plugin name for path lookup #28534, then you see that the whole of block is not there. It was only added in 3 for BC reasons.

[korenevskiy]

@laoneo @astridx
In the final release of Joomla (Joomla! 4.0.5 Stable 11-December-2021), I wrote a component using plugins. and I came across this code.
I think it's a mistake, but I didn't figure it out. You will mean this.

[laoneo]

Made a pr which removes the duplicated code in #36434. You can mark this question as answered.