Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of retries in order to avoid unnecessary attempts for test concoction bottom #255

Open
tomswallaRH opened this issue Feb 9, 2023 · 0 comments
Labels

Comments

@tomswallaRH
Copy link

Jenkins and plugins versions report

Environment
Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?

Jenkins: 2.303.3
OS: Fedora: 37
jms-messaging:1.1.27

Reproduction steps

When the user uses the test connection button and the config is incorrect (wrong pwd, expired certificate, etc.) and the user is stuck on testing, never-ending loop until the connection reaches the maximum 5050 attempt(s)

Expected Results

Notify the user with an appropriate error message and after a few minutes

Actual Results

The Error

[ssl://activemq-broker01.queue.company.com:12345, 
ssl://activemq-broker02.queue.company.com:12345] after: 5050 attempt(s) with 
Cannot send, channel has already failed: tcp://10.0.0.22:12345, 
continuing to retry.

Because of the high number of retries it uses (5050), it takes a long time for the user to get a response
JMS message plugin test concoction bottom if one of these values config is incorrect (wrong pwd, expired certificate, etc.)

Anything else?

This the part that we need to be fixed

JMS message plugin test concoction bottom for user name and password
https://github.com/jenkinsci/jms-messaging-plugin/blob/master/plugin/src/main/java/com/redhat/jenkins/plugins/ci/authentication/activemq/UsernameAuthenticationMethod.java#L121

JMS message plugin test concoction bottom for certificate
https://github.com/jenkinsci/jms-messaging-plugin/blob/master/plugin/src/main/java/com/redhat/jenkins/plugins/ci/authentication/activemq/SSLCertificateAuthenticationMethod.java#L158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant