Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special features not listed for some movies #1293

Open
MelanX opened this issue Oct 28, 2024 · 2 comments
Open

Special features not listed for some movies #1293

MelanX opened this issue Oct 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@MelanX
Copy link
Contributor

MelanX commented Oct 28, 2024

Describe the bug

  1. Open Swiftfin
  2. Click on a movie with special features
  3. See that sometimes they were loaded, sometimes they didn't

Here's a log from where I made the screenshots. I restarted the server, then made screenshots in web browser for all 4 example movies. Then I did the same in the same order on Swiftfin.

  1. Die Tribute von Panem - The Ballad of Songbirds & Snakes
  2. Insidious Chapter 3
  3. A Nighmare on Elm Street
  4. Nightmare on Elm Street 3
    Log: https://gist.github.com/MelanX/badb60ac08f7be9072f8f9a3729d4cb0
Die Tribute von Panem - The Ballad of Songbirds & Snakes

Web Browser

Screenshot 2024-10-28 163412

Swiftfin

IMG_20241028_163532

File System

image

Insidious Chapter 3

Web Browser

Screenshot 2024-10-28 163430

Swiftfin

IMG_20241028_163543

File System

image

A Nighmare on Elm Street

Web Browser

Screenshot 2024-10-28 163456

Swiftfin

IMG_20241028_163613

File System

image

Nighmare on Elm Street 3

Web Browser

Screenshot 2024-10-28 163514

Swiftfin

IMG_20241028_163622

File System

image

Application version

1.3(2)

Where did you install the app from?

TestFlight

Device information

iPhone 14 Pro

OS version

iOS 18.1 (did also happen on iOS 18.0)

Jellyfin server version

10.10.0 (did also happen on 10.9.x)

@MelanX MelanX added the bug Something isn't working label Oct 28, 2024
@JPKribs
Copy link
Member

JPKribs commented Oct 28, 2024

Just to add to this:

Changing 'shorts' to 'extras' resolves this. If I put some in 'shorts' and some in 'extras', I get nothing. The existence of the 'shorts' folder stops all results and I get this:

Error fetching special features: dataCorrupted(Swift.DecodingError.Context(codingPath: [_CodingKey(stringValue: "Index 1", intValue: 1), StringCodingKey(stringValue: "ExtraType", intValue: nil)], debugDescription: "Cannot initialize SpecialFeatureType from invalid String value Short", underlyingError: nil))

I think, from the error, this is just we need to make sure we're accounting for all extras "types" found here:

https://jellyfin.org/docs/general/server/media/movies/#extras-folders

  • behind the scenes
  • deleted scenes
  • interviews
  • scenes
  • samples
  • shorts
  • featurettes
  • clips
  • other
  • extras
  • trailers

I only tested with shorts and extras, but I would guess that other types are impacted as well.

@JPKribs
Copy link
Member

JPKribs commented Oct 28, 2024

Changing 'shorts' to 'extras' resolves this. If I put some in 'shorts' and some in 'extras', I get nothing. The existence of the 'shorts' folder stops all results and I get this:

To clarify this, the existence of any special features in a folder called 'shorts' means that no special features will show up even if they are in a supported folder name.

I'm pretty green on the SDK generation side of Swiftfin, but I think that's where this originates from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants