ForeignKey relation

[DiogoMarques29]

Hi,

I was trying out your app and noticed something weird. Why is a normal ForeignKey (that we are not registering in reversion) showing up on the diff panel? Even if it's empty it always shows 'add: None'. That does not make any sense since this class has the information about that ForeignKey (throw a relational ID). Then I started watching the code and, if I saw correctly, these fields are treated as reversed relations, which they are not.

[amureki]

@DiogoMarques29 have same issue here
I guess, problem is here:
https://github.com/jedie/django-reversion-compare/blob/master/reversion_compare/compare.py#L86

Not sure, how better to compare fields, seems like comparing values is not good enough?

[jedie]

Any idea to fix this? Pull requests are welcome ;)

[alaruss]

Hello,

I fixed this by changing https://github.com/jedie/django-reversion-compare/blob/master/reversion_compare/compare.py#L46 to:
self.value = version_record.field_dict.get(getattr(field, 'attname', field_name), DOES_NOT_EXIST)

And removing this if statement: https://github.com/jedie/django-reversion-compare/blob/master/reversion_compare/compare.py#L92

Frankly, I can't get why in case of the ForeignKey the whole object should be compared.

[jedie]

@alaruss can you contribute a pull request with tests?!?

[alaruss]

@jedie Something like this #100