Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move localization to client #13

Open
fheinfling opened this issue Oct 9, 2019 · 0 comments
Open

Move localization to client #13

fheinfling opened this issue Oct 9, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@fheinfling
Copy link
Member

The issue has been raised after a new locale has been added in #8.
When it comes to localization we're currently using a server and client-side approach.

Currently only remote (push) notifications are localized on server-side. E.g. in

timy-messenger/firebase/functions/localize-util.js

Line 5 in 440fda8

* Building notification title for RSVP update for event author.

We should consider replacing the server-side approach with localizing solely on our clients.

FYI: Previously also system messages were localized in our backend but have been moved back to our clients using the approach described in #8 (comment)
@fheinfling fheinfling added the enhancement New feature or request label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fheinfling